Gitlab hosted package: unable to discover remote git server capabilities: CompressionUnsupported

Continuing the discussion from Issues with gitlab and the package manager:

Weekly CI failed again today:

0.15.0-dev.1393+493265486

/usr/local/bundle/gems/zigrb-0.0.1/ext/build.zig.zon:40:20: error: unable to discover remote git server capabilities: CompressionUnsupported
            .url = "git+https://gitlab.com/fjc/zigby.git#57d01bac78e1a152172d1daee4868593eb1c5156",
                   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
zig failed, exit code 1

Last week was successful with 0.15.0-dev.1271+bb2984673.

If this is a recent regression, please file an issue with a repro on ziglang/zig so we can investigate it before 0.15.0 is tagged.

“http.Client rewrite”:

@@ -1074,12 +1074,10 @@ pub const Request = struct {
                     switch (req.response.transfer_compression) {
                         .identity => req.response.compression = .none,
                         .compress, .@"x-compress" => return error.CompressionUnsupported,
-                        .deflate => req.response.compression = .{
-                            .deflate = std.compress.zlib.decompressor(req.transferReader()),
-                        },
-                        .gzip, .@"x-gzip" => req.response.compression = .{
-                            .gzip = std.compress.gzip.decompressor(req.transferReader()),
-                        },
+                        // I'm about to upstream my http.Client rewrite
+                        .deflate => return error.CompressionUnsupported,
+                        // I'm about to upstream my http.Client rewrite
+                        .gzip, .@"x-gzip" => return error.CompressionUnsupported,
                         // https://github.com/ziglang/zig/issues/18937
                         //.zstd => req.response.compression = .{
                         //    .zstd = std.compress.zstd.decompressStream(req.client.allocator, req.transferReader()),

Thanks for the example. I noticed that it still doesn’t work after the branch:

$ stage4/bin/zig fetch "git+https://gitlab.com/fjc/zigby.git#57d01bac78e1a152172d1daee4868593eb1c5156"
error: unable to discover remote git server capabilities: InvalidPacket

I’ll look into this right away

4 Likes