Need help understand readfileAlloc()

[vulpesx]

@Bobvan

The reason is simple, readFileAlloc() does not querry the file size when reading.
It just initializes arraylist and then streams the data into it. However, this arraylist grows independant to the file size (it will overgrow it).

yes, but also no! When streaming the data, a file reader will redirect to sendFile, making the writer aware it is dealing with a file.

The allocating writer (made from the array list), when doing sendFile does query and allocate the size of the file. However, the allocation logic will @Bobvan showed is still used, so it can, and does in this case, allocate more than the exact size.

This could be changed to more precisely grow when it has a file size, the code to do this already exists… it just isnt used in this code path.

@sc68cal

I would guess that the usage of ArrayList is to make reading the file and manipulating the contents easier, compared to a fixed size buffer

Its just cause the simplest api path to do this happens to use an arraylist.
This api does not, and should not be, manipulating the contents beyond reading and growing.